AP-25585: Add listener to sync 'http.nonProxyHosts' to System properties#52
AP-25585: Add listener to sync 'http.nonProxyHosts' to System properties#52
Conversation
3nol
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where Eclipse incorrectly syncs HTTPS proxies to System properties using https.nonProxyHosts instead of the correct http.nonProxyHosts property. The fix adds a listener that automatically synchronizes the Eclipse proxy configuration to the correct Java System property.
Changes:
- Added a new listener class to monitor proxy configuration changes and sync to the correct System property
- Integrated the listener into the existing proxy service initialization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| NonProxiedHostsChangedListener.java | New listener that monitors Eclipse proxy changes and syncs http.nonProxyHosts System property when HTTPS proxy configuration changes |
| EclipseProxyServiceInitializer.java | Updated to install the new listener during proxy service initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.core/src/eclipse/org/knime/core/eclipseUtil/NonProxiedHostsChangedListener.java
Outdated
Show resolved
Hide resolved
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
9b608e2 to
6dab93a
Compare
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
6dab93a to
96f690e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
96f690e to
e7f3a9e
Compare
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
e7f3a9e to
24a28f0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
24a28f0 to
e3e40eb
Compare
AP-25585 (Eclipse incorrectly syncs HTTPS proxies to System properties using https.nonProxyHosts)
3nol
force-pushed
the
bug/AP-25585-eclipse-incorrectly-syncs-https-proxies
branch
from
e3e40eb to
c3c60c2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
1 participant
AP-25585 (Eclipse incorrectly syncs HTTPS proxies to System properties using https.nonProxyHosts)