AP-25344: Option to remove failed tools from combined tools workflow #33
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-25344 (Properly handle failing tools in combined tools workflow)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for optionally removing failed tools from combined tools workflows. The change introduces a new boolean parameter removeFailedTools that propagates through the Python-Java bridge to control whether failed workflow segments should be removed during execution.
Key Changes:
- Added
removeFailedToolsboolean parameter to the combined tools workflow initialization API - Propagated the parameter through the entire call chain from Python to Java
- Configured
WorkflowSegmentExecutorto respect the new setting viaremoveFailedSegments()
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| _node_backend_launcher.py | Added remove_failed_tools parameter to Python API method signature and forwarded it to Java context |
| PythonToolContext.java | Extended interface to include removeFailedTools parameter in method signature |
| ToolExecutor.java | Added parameter to method signatures and wired it to WorkflowSegmentExecutor.removeFailedSegments() calls; also refactored deprecated workflow copy API |
| DefaultViewContext.java | Updated implementation to pass through the new removeFailedTools parameter |
| CloseablePythonNodeProxy.java | Updated unsupported operation stub to match new interface signature |
org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/proxy/PythonToolContext.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AtR1an
approved these changes
Dec 18, 2025
Contributor
AtR1an
left a comment
AtR1an
left a comment
There was a problem hiding this comment.
Blocked by knime-core merge.
hornm-knime
deleted the
todo/AP-25344-properly-handle-failing-tools-i
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-25344 (Properly handle failing tools in combined tools workflow)