Skip to content

Comments

chore(kno-11406): clarify partials usage#1290

Open
cellomatt wants to merge 12 commits intomainfrom
mk-kno-11406
Open

chore(kno-11406): clarify partials usage#1290
cellomatt wants to merge 12 commits intomainfrom
mk-kno-11406

Conversation

@cellomatt
Copy link
Contributor

@cellomatt cellomatt commented Jan 30, 2026

Description

This PR:

  • Updates usage patterns for partials in light of recent improvements.
  • Adds from_json helper to Liquid helper reference
  • Adds JSON input type to partials schema reference, with example
  • Adds clarity on <style> tags for HTML partials
  • Moves a section about editing HTML partials (with preview pane) to the new HTML partial page
  • Adds FAQ on default schema values in conditions to the partial schema reference, to help with "gotcha" of things like truthy empty strings in a Liquid condition

@cellomatt cellomatt requested review from a team, cjbell and emisilvacab January 30, 2026 16:06
@linear
Copy link

linear bot commented Jan 30, 2026

@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 18, 2026 5:28pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

rachael-t
rachael-t previously approved these changes Jan 30, 2026
@cellomatt cellomatt marked this pull request as ready for review February 13, 2026 21:49
@cellomatt cellomatt dismissed rachael-t’s stale review February 13, 2026 22:11

Lots of new changes, should be reviewed again before merging.

Copy link
Contributor

@samseely samseely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates!

Copy link

@emisilvacab emisilvacab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! My only comment is that the json input type hasn't been released yet (see pr #7364). We should also make sure to add documentation for that under the message type variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants