chore(kno-11675): Clarify workflow execution behavior#1314
chore(kno-11675): Clarify workflow execution behavior#1314
Conversation
- Add new 'Understanding workflow execution behavior' section to debugging-workflows.mdx explaining: - Channel step failures halt workflow after 3 retry attempts (e.g., template rendering errors, invalid config) - Channel step skips allow workflow to continue (conditions not met, missing config, preference opt-outs, missing recipient data) - Update channel-step.mdx to document step failure behavior during execution - Add warning callout to testing-and-debugging.mdx about template errors halting workflows Resolves KNO-11675 Co-authored-by: Matt Kufchak <matt.kufchak@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Matt Kufchak <matt.kufchak@gmail.com>
Send windows delay notifications but don't cause steps to be skipped. Co-authored-by: Matt Kufchak <matt.kufchak@gmail.com>
| You can access the workflow debugger from our "Logs" page, which you'll find in the left hand environment sidebar in the dashboard. From there: | ||
| You can access the workflow debugger from the "Runs" tab on a given workflow or the "Workflow runs" tab on a recipient record. | ||
|
|
||
| You can also access it from our "Logs" page, which you'll find in the left hand sidebar in the dashboard. From there: |
There was a problem hiding this comment.
I think this should technically be left-hand sidebar, but looks like we've used a mix of left hand, left side, and left-hand. I don't have a strong preference and know this came from the original, just noting.
| <Callout | ||
| type="info" | ||
| title="Note:" | ||
| text="You can use the workflow debugger to inspect any workflow run, regardless of whether it was triggered via the API or the dashboard test runner." |
There was a problem hiding this comment.
| text="You can use the workflow debugger to inspect any workflow run, regardless of whether it was triggered via the API or the dashboard test runner." | |
| text="You can use the workflow debugger to inspect any workflow run, whether it was triggered via the API or the dashboard test runner." |
| - **Recipient is missing required data.** If the recipient lacks the data required for delivery on this channel (for example, no `email` address for an email step, or no [channel data](/managing-recipients/setting-channel-data) for a push step), the step is skipped. | ||
| - **A dynamic [batch](/designing-workflows/batch-function), [delay](/designing-workflows/delay-function), or [throttle](/designing-workflows/throttle-function) step encounters an invalid window value.** If a workflow step encounters a missing or invalid dynamic window value (like a timestamp in the past), the step is skipped. | ||
|
|
||
| The workflow debugger will indicate when a step has been skipped and provide the reason, helping you understand why a recipient did not receive a notification on a particular channel or a workflow function was not processed as expected. |
There was a problem hiding this comment.
Can we break this into two sentences?
| - **Template rendering errors.** Invalid Liquid syntax or missing required variables that prevent the message template from rendering. | ||
| - **Fetch step errors.** Errors or timeouts from the HTTP request made by the fetch step. | ||
|
|
||
| You can identify failed steps in the workflow debugger by looking for error states on individual steps. The debugger will show you the error details to help diagnose and fix the issue. |
There was a problem hiding this comment.
I think this would benefit from an image. I can imagine this being hard to follow if you're not already familiar with this
scoti-knock
left a comment
There was a problem hiding this comment.
Left a few suggestions — things like adding an image could be a follow up ticket IMO.
Description
This PR clarifies the expected behavior of workflow execution when a step encounters an error versus when it is intentionally skipped.
Previously, the documentation did not explicitly state that a workflow run would halt if a channel step failed after exhausting its retries. This PR addresses KNO-11675 by:
debugging-workflows.mdxexplaining when workflows halt due to channel step failures (e.g., rendering errors) and when steps are merely skipped (e.g., conditions not met, preferences opt-outs).channel-step.mdxto the new debugging documentation.testing-and-debugging.mdxwith a warning about template rendering errors halting workflow execution.These changes provide a clearer understanding of workflow control flow and aid in debugging.
Tasks
KNO-11675
Linear Issue: KNO-11675