feat: handle useGuides for selectable status indicator in toolbar v2#867
feat: handle useGuides for selectable status indicator in toolbar v2#867thomaswhyyou wants to merge 4 commits intographite-base/867from
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thomaswhyyou
changed the title
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-9
branch
from
3c0d2d8 to
6137965
Compare
thomaswhyyou
changed the base branch from
thomas-kno-11142-sdk-guide-toolbar-v2-poc-8
to
graphite-base/867
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## graphite-base/867 #867 +/- ##
=====================================================
- Coverage 67.64% 67.58% -0.07%
=====================================================
Files 203 203
Lines 8729 8709 -20
Branches 1159 1161 +2
=====================================================
- Hits 5905 5886 -19
+ Misses 2800 2799 -1
Partials 24 24
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| // we are throttling currently and which other guides are unthrottled. | ||
| if (first.bypass_global_group_limit || first.key === stage.resolved) { | ||
| if (snapshot.throttled) { | ||
| return guide.bypass_global_group_limit ? "returned" : "throttled"; |
There was a problem hiding this comment.
Missing includeThrottled check in selectAll status inference
Medium Severity
inferSelectAllByTypeReturnStatus doesn't check query.type?.all?.metadata?.opts?.includeThrottled before returning "throttled", unlike its sibling functions inferSelectByKeyReturnStatus and inferSelectOneByTypeReturnStatus which both respect this option. Since SelectGuidesOpts is aliased to SelectGuideOpts and the actual selectGuides client method uses includeThrottled to decide whether to filter out throttled guides, the toolbar will incorrectly show "throttled" for guides that are actually being returned when a consumer passes includeThrottled: true to useGuides.
1 participant
Description
** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **
Todos
** List any todo items necessary before merging, if any. Delete if none. **
Checklist
Screenshots or videos
** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **