Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "override_preferences": false | ||
| }, | ||
| "steps": [] | ||
| } |
There was a problem hiding this comment.
Accidentally committed broadcast directory at repo root
Medium Severity
The my-new-broadcast/ directory at the repository root looks like a test artifact generated during development of the broadcast new command. Its contents exactly match what scaffoldBroadcastDirBundle produces. It isn't referenced by any source or test file and doesn't belong in the repo.
| const input = flags.force || (await promptToConfirm(promptMessage)); | ||
| if (!input) return; | ||
|
|
||
| await Broadcast.generateBroadcastDir(broadcastDirCtx, key); |
There was a problem hiding this comment.
User-provided name discarded during broadcast generation
Medium Severity
The broadcast new command prompts the user for a name, but the collected value is only used as a slugify seed for the key suggestion. generateBroadcastDir only accepts a key parameter, so scaffoldBroadcastDirBundle always writes name: "". All other resource generators (workflow, guide, email-layout) accept and persist the name into the generated JSON file.
Additional Locations (1)
1 participant
Description
Adds the full set of commands for working with broadcasts via the CLI. Does not include broadcasts in
knock pullfor now because I felt like it doesn't make sense to check those into source control probably?Tasks
KNO-11680