fix(csp): allow cross-subdomain framing for Pro page variant switcher#1331
Closed
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Closed
fix(csp): allow cross-subdomain framing for Pro page variant switcher#1331NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
frame-ancestors 'self' blocked tech/finance variants from rendering inside the Pro landing page iframe. Widen to *.worldmonitor.app. Also adds missing finance.worldmonitor.app to frame-src. Closes koala73#1322 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frame-ancestorsfrom'self'to'self' https://*.worldmonitor.app https://worldmonitor.appso Tech/Finance variants can render inside the Pro landing page iframehttps://finance.worldmonitor.apptoframe-srcdirectivevercel.json,nginx-security-headers.conf,index.htmlRoot Cause
The Pro page (
/pro) embedsworldmonitor.appin an iframe. When users click Tech or Finance in the variant switcher, the iframe navigates totech.worldmonitor.app/finance.worldmonitor.app. Those subdomains' CSPframe-ancestors 'self'policy blocked them from being framed bywww.worldmonitor.app, showing "refused to connect" / "This content is blocked."Test plan
/proCloses #1322
🤖 Generated with Claude Code