fix(globe): correct satellite beam coordinate system to match globe.gl#1344
Merged
fix(globe): correct satellite beam coordinate system to match globe.gl#1344
Conversation
Globe.gl uses GLOBE_RADIUS=100 and theta=(90-lng), not radius=1. Beams were invisible because they were 100x too small inside the globe.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLOBE_R = 100(was 1),theta = (90 - lng)(waslng + 180)0.018to1.8and normalize ground points to globe surface (multiplyScalar(100))Context
The coordinate fix from PR #1342 was committed after the PR was already merged, so the fix never made it to main.
Test plan