Skip to content

Add Spain with its grocery sites to JSON#3560

Open
Alien69Flow wants to merge 2 commits into
koala73:mainfrom
Alien69Flow:Alien69Flow-patch-1
Open

Add Spain with its grocery sites to JSON#3560
Alien69Flow wants to merge 2 commits into
koala73:mainfrom
Alien69Flow:Alien69Flow-patch-1

Conversation

@Alien69Flow
Copy link
Copy Markdown

@Alien69Flow Alien69Flow commented May 2, 2026

Summary

Type of change

  • Bug fix
  • New feature
  • New data source / feed
  • New map layer
  • Refactor / code cleanup
  • Documentation
  • CI / Build / Infrastructure

Affected areas

  • Map / Globe
  • News panels / RSS feeds
  • AI Insights / World Brief
  • Market Radar / Crypto
  • Desktop app (Tauri)
  • API endpoints (/api/*)
  • Config / Settings
  • Other:

Checklist

  • Tested on worldmonitor.app variant
  • Tested on tech.worldmonitor.app variant (if applicable)
  • New RSS feed domains added to api/rss-proxy.js allowlist (if adding feeds)
  • No API keys or secrets committed
  • TypeScript compiles without errors (npm run typecheck)

Screenshots

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

@Alien69Flow is attempting to deploy a commit to the World Monitor Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the trust:caution Brin: contributor trust score caution label May 2, 2026
@Alien69Flow Alien69Flow closed this May 2, 2026
@Alien69Flow Alien69Flow reopened this May 2, 2026
@github-actions github-actions Bot added the trust:safe Brin: contributor trust score safe label May 2, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 2, 2026

Greptile Summary

Adds Spain (ES) as a new country entry to the grocery basket config with 10 retailer domains and EUR currency, and fixes a missing trailing newline. The EUR FX symbol is already present in fxSymbols, so no mapping update is needed; the seed script (seed-grocery-basket.mjs) will pick up the new entry automatically on next run via loadSharedConfig.

Confidence Score: 4/5

Safe to merge — data-only JSON change with no P0/P1 issues

The change is confined to a single JSON config file. EUR is already in fxSymbols, the seed script auto-discovers the new country, and the JSON is structurally valid. Only a P2 concern about two same-group retailers.

No files require special attention

Important Files Changed

Filename Overview
shared/grocery-basket.json Adds Spain (ES, EUR) with 10 grocery sites and fixes a missing trailing newline; fxSymbols already covers EUR so no currency mapping needed; minor issue with two sites from the same El Corte Inglés group

Sequence Diagram

sequenceDiagram
    participant JSON as grocery-basket.json
    participant Seed as seed-grocery-basket.mjs (Railway)
    participant EXA as EXA Search API
    participant FC as Firecrawl (fallback)
    participant Redis as Redis Cache

    Seed->>JSON: loadSharedConfig('grocery-basket.json')
    JSON-->>Seed: countries[...ES{mercadona.es, carrefour.es, ...}]
    loop For each country (incl. Spain)
        loop For each basket item
            Seed->>EXA: search(item.query, includeDomains: country.sites, userLocation: ES)
            EXA-->>Seed: results with price summaries
            alt price found
                Seed->>Seed: extractPrice() + outlier gate
            else no price
                Seed->>FC: scrape(url, expectedCurrency=EUR)
                FC-->>Seed: {price, currency}
            end
        end
    end
    Seed->>Redis: SET economic:grocery-basket:v1 (10 days TTL)
Loading

Reviews (1): Last reviewed commit: "Add Spain with its grocery sites to JSON" | Re-trigger Greptile

Comment thread shared/grocery-basket.json
@Alien69Flow
Copy link
Copy Markdown
Author

por cierto para calcular realmente la infalcion habria que tener en cuenta mas productos y servicios de alimentacion y sobre todo energia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trust:caution Brin: contributor trust score caution trust:safe Brin: contributor trust score safe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant