Update tutorial to get the latest release of Kokkos#92
Merged
cedricchevalier19 merged 2 commits intokokkos:mainfrom Jun 23, 2024
Merged
Update tutorial to get the latest release of Kokkos#92cedricchevalier19 merged 2 commits intokokkos:mainfrom
cedricchevalier19 merged 2 commits intokokkos:mainfrom
Conversation
JBludau
reviewed
Jun 13, 2024
Kokkos hopefully does not export iostream anymore.
cedricchevalier19
force-pushed
the
kokkos-latest
branch
from
a666953 to
b82fa68
Compare
JBludau
reviewed
Jun 14, 2024
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
Would you be fine with splitting it into two, one bumping the version, the other fixing the includes? Just to have a clean history in the repo
aprokop
approved these changes
Jun 14, 2024
Member
Author
The include fix can go first but I do not think it will make a lot of differences on the history side. |
JBludau
approved these changes
Jun 14, 2024
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
I guess it is fine. But I would love if the title would reflect the fact that missing includes were fixed, too. But no hard feelings about this
masterleinad
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after #91 .