fix: remove var redeclaration in syncSkillsHiddenInput to prevent variable shadowing#617
Conversation
|
@akhilmodi29 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita Please review this PR and add the required labels including gssoc:approved. This fixes the variable shadowing bug in syncSkillsHiddenInput — the hidden skills input is now correctly updated, ensuring selected skills are properly passed to the recommendation API. level:intermediate |
|
@komalharshita Please review and merge with appropriate labels including gssoc: approved |
|
@komalharshita Please Review and merge with all appropriate labels including gssoc: approved |
|
@komalharshita Please Review and merge with all appropriate labels including gssoc: approved |
What does this PR do?
Fixes a variable shadowing bug in
syncSkillsHiddenInput()whereskillsHiddenwas being re-declared withvarinside anifblock, potentially causing selected skills to not be passed correctly to the recommendation API.Changes Made
varkeyword from inside theifblock insyncSkillsHiddenInput()instatic/script.jsskillsHiddenvariable is now correctly updated instead of a new local variable being createdType of Change
Testing
python app.pyRelated Issue
Closes #616