Addressed review comments: refactored skills.js and implemented reset#634
Addressed review comments: refactored skills.js and implemented reset#634pavithapari wants to merge 5 commits into
Conversation
|
@pavithapari is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita Thanks for the detailed review and feedback. As suggested in the previous review comments, This PR is part of addressing the concerns raised in the earlier review regarding:
Current scope of this PR:
The unrelated UI/layout and merge-conflict recovery work will be handled in separate PRs. |
…fixed the broken genrate projects
381f4a6 to
f328b9f
Compare
|
@komalharshita Please review this PR |
|
@pavithapari kindly resolve the merge conflicts |
Resolved the Merge Conflicts. Please review it |
Summary [required]
Refactored
script.jsto improve overall stability and maintainability while keeping the existing structure and behaviour intact. Fixed broken bracket/closure issues in the generated projects rendering and form submission flow, cleaned up nested logic, and improved the reset functionality so filters, selected skills, quick-pick states, and suggestion inputs are properly cleared without leaving stale UI state.Related Issue [required]
Closes #170
Type of Change [required]
What Was Changed [required]
static/js/script.jsstatic/js/script.jsstatic/js/script.jsstatic/js/script.jsstatic/js/script.jsHow to Test This PR [required]
Clone this branch:
Install dependencies:
Run the app:
Open:
Verify the following:
Run the tests:
Expected output:
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsScreen.Recording.2026-05-26.201524.mp4