fix: resolve syntax issues in recommendation flow#714
Conversation
|
@nirvani-nj is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
I reviewed the changes and verified that this PR cleans up the recommendation form submission flow by removing duplicated logic, restoring a consistent request lifecycle, and improving error handling.
The updated implementation correctly preserves form validation, loading state management, API request handling, and result rendering while simplifying the control flow. The renderResults() cleanup also removes redundant conditions without changing existing behavior.
The changes are focused, improve maintainability, and directly address the reported syntax and flow issues without introducing unrelated functionality.
Looks good to me and is ready to be merged.
Before merging, kindly resolve the merge conflicts
|
I checked the failing CI jobs. All recommendation-flow tests pass. The only failing test is:
The failure is:
The workflow installs dependencies from This appears to be unrelated to the changes in this PR ( |
|
@nirvani-nj kindly resolve the merge conflicts |
Summary [required]
This PR fixes multiple syntax issues in
static/script.jsthat were breaking the recommendation flow on the homepage.The malformed JavaScript prevented the file from parsing completely, which caused skill chip input, autocomplete suggestions, quick-pick interactions, and recommendation form submission to stop working. The PR cleans up the broken submit handler and fixes the malformed
renderResults()logic to restore normal frontend behaviour.Related Issue [required]
Related to frontend recommendation flow fixes discovered while working on #324
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/script.jsrenderResults()implementationHow to Test This PR [required]
Clone this branch:
Install dependencies:
Run the app:
Open:
Test the homepage flow:
Confirm recommendations render successfully without console syntax errors.
Test Results [required]
Screenshots (if UI change)
N/A — no UI changes were introduced.
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR focuses only on restoring valid frontend functionality after malformed merge conflicts introduced duplicated conditionals and incomplete closures inside
static/script.js.