Fix/dark mode persistence#772
Open
Ayush-kathil wants to merge 3 commits into
Open
Conversation
- Initialize global cache variables in data_loader.py - Fix duplicate project IDs in projects.json - Replace Django escapejs with Jinja tojson filter in project.html
…polar-sky-streaks-08h35
|
@Ayush-kathil is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc-2026
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #746
Description
This pull request fixes a bug where the user's dark mode preference would reset to light mode on every page reload.
Changes Made
initTheme()instatic/script.jsto retrieve the saved theme fromlocalStorageif it exists.try/catchblock around thelocalStoragecall to prevent JavaScript execution errors for users with strict privacy settings that block local storage access.localStorageis empty or unavailable, it safely falls back to thedata-themeattribute or defaults to"light".Testing
python tests/test_basic.pytest suite passes successfully.