fix: keyboard trap for GitHub modal and tooltip aria-hidden#799
Open
EshaniKatiyar wants to merge 1 commit into
Open
fix: keyboard trap for GitHub modal and tooltip aria-hidden#799EshaniKatiyar wants to merge 1 commit into
EshaniKatiyar wants to merge 1 commit into
Conversation
|
@EshaniKatiyar is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@komalharshita Pls review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two keyboard accessibility issues flagged in #25.
Changes
templates/index.htmlaria-hidden="true"to decorative tooltips so screen readers skip themstatic/script.jsImplemented focus trap for the GitHub modal — Tab and Shift+Tab now cycle within the modal while it's open
Focus returns to the trigger element on modal close
Testing
Tabbed through the page with no mouse — focus no longer escapes the modal
No visual changes
Closes #25