Skip to content

fix: keyboard trap for GitHub modal and tooltip aria-hidden#799

Open
EshaniKatiyar wants to merge 1 commit into
komalharshita:mainfrom
EshaniKatiyar:fix/keyboard-accessibility
Open

fix: keyboard trap for GitHub modal and tooltip aria-hidden#799
EshaniKatiyar wants to merge 1 commit into
komalharshita:mainfrom
EshaniKatiyar:fix/keyboard-accessibility

Conversation

@EshaniKatiyar
Copy link
Copy Markdown

Summary

Fixes two keyboard accessibility issues flagged in #25.

Changes

templates/index.html

  • Added aria-hidden="true" to decorative tooltips so screen readers skip them

static/script.js

  • Implemented focus trap for the GitHub modal — Tab and Shift+Tab now cycle within the modal while it's open

  • Focus returns to the trigger element on modal close

Testing

  • Tabbed through the page with no mouse — focus no longer escapes the modal

  • No visual changes

Closes #25

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 7, 2026

@EshaniKatiyar is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@EshaniKatiyar
Copy link
Copy Markdown
Author

@komalharshita Pls review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add keyboard accessibility improvements

1 participant