fix(icon): use contrast color for filled warning icon-item (#DS-5085)#1643
Merged
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit 931f1ad): https://koobiq-next--prs-1643-stv0e2mq.web.app (expires Tue, 23 Jun 2026 10:45:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
lskramarov
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
В светлой теме иконка в filled warning icon-item (fade-off) была белой
(
--kbq-icon-white) на жёлтом фоне--kbq-background-warning, что давалоплохой контраст. Цвет иконки заменён на
--kbq-icon-contrast(тёмный всветлой теме), как в макете Figma (DS-5085).
List of notable changes:
--kbq-icon-item-filled-fade-off-warning-colorс--kbq-icon-whiteна--kbq-icon-contrastWhat should reviewers focus on?
(в тёмной теме
--kbq-icon-contrastстановится светло-серым).