Update Maven Central coordinates to "org.korge" and switch publishing to vanniktech plugin#2362
Conversation
🤖 Augment PR SummarySummary: Migrates KorGE’s Maven/Gradle coordinates to the Changes:
Technical Notes: Adds the Central Portal snapshots repository ( 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
I went over the changes and it looks quite a lot of work for renaming and configuring a new plugin for publishing. I think there is much to improve here over time.
Once this is done I would recommend moving the gradle plugins into separate repo, as they are not mandatory for KorGE nor do they have anything in common. If they are providing useful stuff for the korge repo or consumers and have to be published for this reason, they should in my opinion follow their own release cycle. This would also decouple korge from gradle plugins and simplify a lot the overall gradle config stuff. Additionally:
- I'd change the URL in the license from
masterbranch tomain, as there is no master branch in the project and it is just an alias for main
I haven't tried it out yet, nor have I searched the project for other references of the old namespace (plan to do that). But what will be very important is
- Add to the README the namespace change, as this is a breaking change and most consumers will have to update their imports.
I would even recommend creating a major release because of that, but if it is well documented, perhaps we can also allow a minor release.
Yes, that is an good idea. I would do this in separate PRs later.
Fully agree. Let's work on main branch towards release 7.0.0 |
80a3b7c to
1470cad
Compare
- Trying to get snapshot publishing working
|
Checked with publishing |
No description provided.