Skip to content

Update Maven Central coordinates to "org.korge" and switch publishing to vanniktech plugin#2362

Merged
jobe-m merged 21 commits into
mainfrom
jobe/move-maven-coordinates-to-org.korge
May 8, 2026
Merged

Update Maven Central coordinates to "org.korge" and switch publishing to vanniktech plugin#2362
jobe-m merged 21 commits into
mainfrom
jobe/move-maven-coordinates-to-org.korge

Conversation

@jobe-m
Copy link
Copy Markdown
Member

@jobe-m jobe-m commented Apr 28, 2026

No description provided.

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 28, 2026

🤖 Augment PR Summary

Summary: Migrates KorGE’s Maven/Gradle coordinates to the org.korge.* namespace and replaces the bespoke Sonatype OSSRH staging/release logic with the com.vanniktech.maven.publish plugin targeting the Central Portal.

Changes:

  • Updates group IDs and Gradle plugin IDs (engine/library/settings/kproject) and adjusts E2E builds to consume the new coordinates.
  • Reworks publishing setup in BuildSrc and plugin modules to use mavenPublishing (including richer POM metadata).
  • Removes legacy Sonatype REST automation (start/close/promote) and OSSRH snapshot repository references.
  • Updates CI publishing workflow to run publishToMavenCentral with Central Portal credentials and in-memory signing key env vars.
  • Refreshes various dependency/tool versions and updates Gradle wrappers in E2E projects.

Technical Notes: Adds the Central Portal snapshots repository (https://central.sonatype.com/repository/maven-snapshots) to multiple builds to support resolving/publishing snapshot artifacts.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread README.md Outdated
Comment thread buildSrc/src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt
Comment thread buildSrc/src/main/kotlin/korlibs/modules/Sonatype.kt Outdated
Comment thread e2e/e2e-test-integration/swiftui/korge-hello-world/build.gradle.kts
@jobe-m jobe-m marked this pull request as draft April 28, 2026 15:34
Copy link
Copy Markdown

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the changes and it looks quite a lot of work for renaming and configuring a new plugin for publishing. I think there is much to improve here over time.

Once this is done I would recommend moving the gradle plugins into separate repo, as they are not mandatory for KorGE nor do they have anything in common. If they are providing useful stuff for the korge repo or consumers and have to be published for this reason, they should in my opinion follow their own release cycle. This would also decouple korge from gradle plugins and simplify a lot the overall gradle config stuff. Additionally:

  • I'd change the URL in the license from master branch to main, as there is no master branch in the project and it is just an alias for main

I haven't tried it out yet, nor have I searched the project for other references of the old namespace (plan to do that). But what will be very important is

  • Add to the README the namespace change, as this is a breaking change and most consumers will have to update their imports.

I would even recommend creating a major release because of that, but if it is well documented, perhaps we can also allow a minor release.

Comment thread buildSrc/src/main/kotlin/korlibs/modules/Signing.kt Outdated
Comment thread buildSrc/src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt Outdated
Comment thread korge-gradle-plugin/src/main/kotlin/korlibs/modules/Signing.kt Outdated
Comment thread korge-gradle-plugin/src/main/kotlin/korlibs/root/RootKorlibsPlugin.kt Outdated
@jobe-m
Copy link
Copy Markdown
Member Author

jobe-m commented May 2, 2026

I went over the changes and it looks quite a lot of work for renaming and configuring a new plugin for publishing. I think there is much to improve here over time.

Once this is done I would recommend moving the gradle plugins into separate repo, as they are not mandatory for KorGE nor do they have anything in common. If they are providing useful stuff for the korge repo or consumers and have to be published for this reason, they should in my opinion follow their own release cycle. This would also decouple korge from gradle plugins and simplify a lot the overall gradle config stuff. Additionally:

Yes, that is an good idea. I would do this in separate PRs later.

I would even recommend creating a major release because of that, but if it is well documented, perhaps we can also allow a minor release.

Fully agree. Let's work on main branch towards release 7.0.0

@jobe-m jobe-m force-pushed the jobe/move-maven-coordinates-to-org.korge branch from 80a3b7c to 1470cad Compare May 7, 2026 08:14
@jobe-m jobe-m marked this pull request as ready for review May 8, 2026 08:21
Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/publish.yml
Comment thread buildSrc/src/main/kotlin/korlibs/modules/Publishing.kt
Comment thread korge/README.md Outdated
Comment thread build.gradle.kts
@jobe-m
Copy link
Copy Markdown
Member Author

jobe-m commented May 8, 2026

Checked with publishing SNAPSHOT-release to MavenLocal, building and testing my korge-fleks based game application. Looks fine.

@jobe-m jobe-m merged commit 42a995a into main May 8, 2026
6 checks passed
@jobe-m jobe-m deleted the jobe/move-maven-coordinates-to-org.korge branch May 8, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants