Try to fix signing of publication artifacts#6
Conversation
🤖 Augment PR SummarySummary: Updates Maven Central publishing/signing configuration to better match the Vanniktech maven-publish plugin’s expected property names. Changes:
Technical Notes: Adds Dokka Gradle plugin mode flag to keep Dokka v1 task behavior with Dokka 2.x. 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 18 18
Lines 428 428
Branches 103 103
=====================================
Misses 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
augment review |
| return System.getenv("ORG_GRADLE_PROJECT_signingInMemoryKey").isPresent() || | ||
| System.getenv("ORG_GRADLE_PROJECT_signingKey").isPresent() || | ||
| findProperty("signingInMemoryKey")?.toString().isPresent() || | ||
| findProperty("signing.secretKeyRingFile")?.toString().isPresent() || |
There was a problem hiding this comment.
hasSigningCredentials() treats signing.secretKeyRingFile as “present” based only on the property being non-blank; if the path is set but the file doesn’t exist, this will still enable publishToMavenCentral()/signAllPublications() and likely fail later. Consider also validating that the referenced file exists before considering credentials present.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
No description provided.