Skip to content

Try to fix signing of publication artifacts#6

Merged
jobe-m merged 6 commits into
mainfrom
feature/Fix-signing
Mar 26, 2026
Merged

Try to fix signing of publication artifacts#6
jobe-m merged 6 commits into
mainfrom
feature/Fix-signing

Conversation

@jobe-m
Copy link
Copy Markdown
Member

@jobe-m jobe-m commented Mar 26, 2026

No description provided.

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Mar 26, 2026

🤖 Augment PR Summary

Summary: Updates Maven Central publishing/signing configuration to better match the Vanniktech maven-publish plugin’s expected property names.

Changes:

  • Switch DEPLOY signing env vars to signingInMemoryKey/signingInMemoryKeyPassword and bump macOS runners to macos-latest
  • Bump DOCS workflow Java to 21
  • Add legacy->Vanniktech property mapping and ignore blank credential values in Gradle
  • Only enables Central publishing/signing when signing credentials are detected

Technical Notes: Adds Dokka Gradle plugin mode flag to keep Dokka v1 task behavior with Dokka 2.x.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread build.gradle.kts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6bc170b) to head (acdcd29).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main      #6   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         18      18           
  Lines        428     428           
  Branches     103     103           
=====================================
  Misses       428     428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jobe-m
Copy link
Copy Markdown
Member Author

jobe-m commented Mar 26, 2026

augment review

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread build.gradle.kts
return System.getenv("ORG_GRADLE_PROJECT_signingInMemoryKey").isPresent() ||
System.getenv("ORG_GRADLE_PROJECT_signingKey").isPresent() ||
findProperty("signingInMemoryKey")?.toString().isPresent() ||
findProperty("signing.secretKeyRingFile")?.toString().isPresent() ||
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasSigningCredentials() treats signing.secretKeyRingFile as “present” based only on the property being non-blank; if the path is set but the file doesn’t exist, this will still enable publishToMavenCentral()/signAllPublications() and likely fail later. Consider also validating that the referenced file exists before considering credentials present.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jobe-m jobe-m merged commit 8efd2e0 into main Mar 26, 2026
16 checks passed
@jobe-m jobe-m deleted the feature/Fix-signing branch March 26, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant