Add support for specifying (named) Firestore database ID#147
Open
ochoalopezalfredo wants to merge 1 commit intokossnocorp:mainfrom
Open
Add support for specifying (named) Firestore database ID#147ochoalopezalfredo wants to merge 1 commit intokossnocorp:mainfrom
ochoalopezalfredo wants to merge 1 commit intokossnocorp:mainfrom
Conversation
…etFirestore` in Firebase adapters, to allow connections to named databases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the Firestore database ID when initializing Typesaurus. This is useful for projects using multiple databases within a single Firebase project or when connecting to a non-default database.
Changes:
Updated TypesaurusCore.Options interface in
src/types/core.tsto include the optional database property.Updated Firestore initialization in admin
src/adapter/admin/firebase.mjsand websrc/adapter/web/firebase.mjsadapters to pass thedatabase Idto thegetFirestorefunction.Bumped package version to
10.7.1inpackage.jsonUpdated
CHANGELOG.mdfileUsage Example:
@kossnocorp #130 issue