Bugfix DB Cache E2E Tests not actually running with --db-push-drafts-to-git=true flag - #1143
Draft
Catalin-Stratulat-Ericsson wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
efiacor
marked this pull request as ready for review
July 30, 2026 08:35
efiacor
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 30, 2026 08:35
dosubot
Bot
added
the
size:S
|
Contributor
|
Just to also add a note here: DB push to git feature has a lot of problems and obscure edge cases which fail. Currently working on a full refactor of it which will solve all of these. This should only be merged once that is in to avoid unnecessarily chasing more known bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix DB Cache E2E Tests not actually running with --db-push-drafts-to-git=true flag
NOTE PLEASE BE AWARE THE 2 PRS BELOW MUST BE MERGED IN BEFORE THIS ONE. E2E TESTS WILL FAIL UNTIL THOSE FIXES ARE IN
--db-push-drafts-to-git=true#1141Description
--db-push-drafts-to-git=trueflag but is in factfalseRelated Issue(s)
--db-push-drafts-to-git=trueflag #1140Type of Change
Checklist
Testing Instructions (Optional)
Additional Notes (Optional)
AI Disclosure
If so, please describe how: