Add go.mod replace directive guard to release workflows - #1144
Merged
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
aravindtga
marked this pull request as ready for review
July 29, 2026 16:52
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 29, 2026 16:52
dosubot
Bot
added
the
size:XS
liamfallon
approved these changes
Jul 30, 2026
efiacor
reviewed
Jul 30, 2026
efiacor
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
release.yamlandimage-build-push-release.yamlworkflows that checks for activereplacedirectives ingo.modandapi/go.mod.replacedirectives (e.g. local path overrides left from development) produces broken images or binaries, consumers cannot resolve local replace targets. This gate catches the mistake before the build proceeds.kptdev/kpt/.github/actions/check-go-mod-replace@main(introduced in Add go.mod replace directive guard to release workflows kpt#4671). The action semantically parsesgo.modusinggo mod edit -jsonandjq, filtering out allowed replacements (k8s.io/apiserver). If unexpected replacements are found, the step emits a GitHub Actions error annotation and exits non-zero, blocking the release.For
image-build-push-release.yaml, a newcheck-replace-directivesjob gates thebuild-and-push-imagematrix job vianeeds.Related Issue(s)
Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to implement and locally validate the workflow changes and draft PR message.