Make pg_gpu pip-installable from PyPI#116
Conversation
|
@mufernando will you try this branch out on your setup? |
|
Why are we pinned to python <3.13? This is going to be annoying when integrating pg_gpu into existing pipelines/environments. Is it because of CUDA toolchain or kvikio? Glancing through the lock file, it's not obvious to me where the constraint is. |
|
ah good catch. we're not in capping the install in |
|
also -- i'm 95% confident everything (including the cuda stack) installs via pip cleanly, so we can publish to pypi |
|
installs and imports fine for me with python3 -m pip install "git+https://github.com/kr-colab/pg_gpu.git@feature/pip-installable-deps"
python3 -c "import pg_gpu"(whereas main branch fails as expected on import) |
|
excellent. when we merge this we can publish to pypi |
mufernando
left a comment
There was a problem hiding this comment.
sorry for the delay! it works for me as well. thanks, @andrewkern!
Closes #115.
The easiest fix here is to copy our pixi env info (
pixi.toml) topyproject.toml. Currentlypyproject.tomldeclared no dependencies at all -- every runtime requirement lived only inpixi.toml(by design), so a pip install produced a package that couldn't import.Changes
path.
Install paths