Open
Conversation
Author
|
@krathjen can't seem to be able to add you as a reviewer, so pinging you for visibility just in case! |
Owner
|
Hey Matteo! Thanks for the PR. I really appreciate it. I’d like to implement a CLA workflow for the repo, but I’ll need a bit more time to set that up. I’ll circle back soon once it’s ready. Thanks for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support to proxy attributes by replacing the previous handling logic, which was just removing them from serialization.
CHANGES:
When a proxy attribute is found on the duplicated node, it'll be "un-proxied" -- which simply means that it'll be deleted and re-created as a standard dynamic attribute -- in order for the keys to be correctly serialized on disk.
Finally, when loading back the animation onto the actual proxy attribute, Maya will automatically wire things so the keys will end up onto the real attribute and not its proxy representation.
NOTE:
This has been used for almost a year in production without issues so far, so I figured it was safe to contribute back to the source repository for everyone to have access to the feature!
Fixes #366