Add mesh support for 2D boundary curve of rectangle#66
Open
sbadrian wants to merge 1 commit intokrcools:masterfrom
Open
Add mesh support for 2D boundary curve of rectangle#66sbadrian wants to merge 1 commit intokrcools:masterfrom
sbadrian wants to merge 1 commit intokrcools:masterfrom
Conversation
The naming "meshrect" is not ideal, I would have prefered "meshrectangle". However, meshrectangle is already used for the triangulation of udim=2 and udim=3 rectangles. I would consider renaming this to "meshplate" in analogy to meshcircle (boundary) and meshdisk (triangulation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naming "meshrect" is not ideal, I would have prefered "meshrectangle".
However, meshrectangle is already used for the triangulation of udim=2 and udim=3 rectangles.
I would consider renaming this to "meshplate" in analogy to meshcircle (boundary) and meshdisk (triangulation)