-
Notifications
You must be signed in to change notification settings - Fork 3
Refinement of domino method #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChristopherMancuso
wants to merge
6
commits into
main
Choose a base branch
from
domino-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The main functions to look at are
Some example code to run Geneplexus with clustering is |
* added default params to API except kwargs * renamed data_dir to file_lovc in cli * flipped behavior of autodownloader and renamed it * updated some defaults and changed parameter names * removed the quite argument * updated help in pipeline control arguments * updated some of the clustering arguments in cli * updated cluster_input to take None for kwargs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added defaults for fit in CLI * updated params for small edgelist in CLI * renamed outdir to output_dir * added defaults for save_class added ALL_SAVES * changed how output_dir of None is handled * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * cleaned up some config params * updated Types in config * added cluster kwargs to config * changed what file scale is saved to * changed how logreg_kwargs called --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* got old tests working * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added new tests for clustering and res params * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed save name bug for windows * change min python v3.10 and latest v3.13 * tmp remove py v3.13 * tmp keep only py v 3.10 * pipeline test now sets -fl * pipeline test now sets -sr to Mouse for cli * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated assertion to be Mouse-Combined * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add back in test for py v3.11 * add back in test for py v3.12 * change requirements to greater than * tmp remove domino from pytests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add back in test for py v3.13 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* changed docs packages to be >= * updated pre-commit-config.yaml based on #303 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests to not be duplicated in PRs * updated tests to not be duplicated in PRs take 2 * removed safe from black in pre-commit yaml * change pre-commit back to normal * changes from rolling back reorder and black * updated the main RTD figure * added new functions to geneplexus.geneplexus page * added clust_kwargs defaults to docs * updated the main RTD figure * swapped order to have input_genes worked if added in class * updates to main RTD page * updated to how to use with R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated RTD CLI page * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change data_dir to file_loc in download.py * added None as file_loc option in download.py * updated some doc strings in download.py * updated download code in RTD API doc * updated RTD API page * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add logreg_kward to have defaults other than None * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removed fucntions starting with _ * stopped properties from showing up * added all class methods to atribute doc strings * added to example to get all major outputs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated the examples scripts * updated the examples scripts typos * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removed geneplexus CLI args from README * small README changes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is for checking the domino implementation and improving it as needed. Some items that might be considered are
Questions
retain_relevant slicesit finds them using connected components, might need to change to louvain for really dense networks at some point?retain_relevant_slices, why did they not use number of pertubed nodes in cc instead of all pertubed nodes?retain_relevant_slcieswhy doeshypergeomuse G_org for universe but only perturbed nodes found in G_modularity (this doesn’t account for perturbed nodes not in slices))?prune_slice, sincerelevant_slicesfound with G_modularity, why look at them in the context of the full graph (G) here?prune_sliceand inrun_pcstand inlinear_thresholdwe can set the threshold and influence values of a node, do we need to do this ever?prune_sliceand inrun_pcst,vertices_prizesseem to be mix of floats and booleans (i.e. Active value), is this OK?prune_slicetheget_putatiave_modulesis really working, should this be changed at all? In particularcur_modularity <= best_modularity + improvement_deltamakes no sense to me and seems like if anything that should be a>=signThings I noticed in domino implementation
linear_thresholdonly uses G_cc, then diffusion step only add scores forfast_pcst, but not nodes outside of G_cc. So does this mean all "propagated genes" come from finding relevant slices (and not diffusion) and then diffusion can just prune those.prune_sliceand inget_putative_modules, full_G and module_threshold are dropped from arguments. In original DOMINO there was code about finding sig_values for each sub-slice but those sig_values were never actually usedfinal_modules(and other places), modules that are below the min_clust_size parameters are included in the p-value adjustment calculations and they should probably be removed beforehand