Allow text selection while isSelectable = true but isEditable = false

[cxa]

as commit message

[CLAassistant]

All committers have signed the CLA.

[krzyzanowskim]

Suggested change

	!isFirstResponder
	!isFirstResponder && isSelectable

do you think it should check for isSelectable? That condition would match the Mac version

[cxa]

With !isFirstResponder && isSelectable, you can't edit under this case:

textView.isEditable = true
textView.isSelectable = false

So I suggest

!isFirstResponder && (isEditable || isSelectable)

But the problem is, you can't avoid selection under this case with above logic:

textView.isEditable = true
textView.isSelectable = false

Maybe we should add some documentation to clarify that when isEditable = true, isSelectable will be ignored.

[cxa]

Closed due to uncertainty.

[krzyzanowskim]

don’t close it yet. we need that. I didn’t have time to test it

[cxa]

Sorry, I thought you would have other design decisions and this PR might block.