Also adds the score dropoff to PE path#603
Merged
Merged
Conversation
marcelm
reviewed
Jul 3, 2026
e1db72b to
027ab12
Compare
PR #601 fixed only for SE path plus for rescue in PE mode. This PR completes the changes to also use score-based dropoff for the pairing of NAMs(/chains). Is-new-baseline: yes
027ab12 to
5a3986c
Compare
Collaborator
|
I confirm that there is nearly no difference in accuracy, and no discernible difference in runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #601 fixed only for the SE path, plus for rescue function in PE mode. This PR completes the changes to also use score-based dropoff for the pairing of NAMs(/chains).
Neither runtime nor accuracy changes significantly (see accuracy experiment below). The fix is for consistency in approach.
Paired-end alignment, 200k PE reads