Skip to content

Also adds the score dropoff to PE path#603

Merged
marcelm merged 1 commit into
mainfrom
score-dropoff-fix-pe
Jul 3, 2026
Merged

Also adds the score dropoff to PE path#603
marcelm merged 1 commit into
mainfrom
score-dropoff-fix-pe

Conversation

@ksahlin

@ksahlin ksahlin commented Jun 12, 2026

Copy link
Copy Markdown
Owner

PR #601 fixed only for the SE path, plus for rescue function in PE mode. This PR completes the changes to also use score-based dropoff for the pairing of NAMs(/chains).

Neither runtime nor accuracy changes significantly (see accuracy experiment below). The fix is for consistency in approach.

Paired-end alignment, 200k PE reads

Genome Len Tool Acc% Δ vs main
chrY 100 main 44.259%  
chrY 100 score-dropoff 44.279% +0.020%
chrY 250 main 55.867%  
chrY 250 score-dropoff 55.870% +0.004%
chrY 500 main 67.846%  
chrY 500 score-dropoff 67.842% −0.004%
CHM13 100 main 93.525%  
CHM13 100 score-dropoff 93.527% +0.002%
CHM13 250 main 95.396%  
CHM13 250 score-dropoff 95.396% +0.000%
CHM13 500 main 96.919%  
CHM13 500 score-dropoff 96.919% +0.000%
Maize 100 main 87.396%  
Maize 100 score-dropoff 87.378% −0.018%
Maize 250 main 95.942%  
Maize 250 score-dropoff 95.943% +0.001%
Maize 500 main 98.442%  
Maize 500 score-dropoff 98.444% +0.002%

Comment thread src/mapper.rs Outdated
@marcelm marcelm force-pushed the score-dropoff-fix-pe branch 2 times, most recently from e1db72b to 027ab12 Compare July 3, 2026 20:51
PR #601 fixed only for SE path plus for rescue in PE mode.
This PR completes the changes to also use score-based dropoff for the
pairing of NAMs(/chains).

Is-new-baseline: yes
@marcelm marcelm force-pushed the score-dropoff-fix-pe branch from 027ab12 to 5a3986c Compare July 3, 2026 20:53
@marcelm

marcelm commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

I confirm that there is nearly no difference in accuracy, and no discernible difference in runtime.

@marcelm marcelm merged commit 23da571 into main Jul 3, 2026
7 checks passed
@marcelm marcelm deleted the score-dropoff-fix-pe branch July 3, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants