Skip to content

feat(web): add about dialog#113

Open
ddc-baiye wants to merge 1 commit into
kubeedge:mainfrom
ddc-baiye:feat/about-dialog
Open

feat(web): add about dialog#113
ddc-baiye wants to merge 1 commit into
kubeedge:mainfrom
ddc-baiye:feat/about-dialog

Conversation

@ddc-baiye
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds an "About" dialog to the KubeEdge Dashboard, accessible via the user profile dropdown menu in the top navigation bar. It provides users with quick access to project information and official links.

Which issue(s) this PR fixes:

Fixes # (None)

Special notes for your reviewer:
The changes include:

  1. Created a new AboutDialog component displaying the logo, description, and links.
  2. Integrated the "About" menu item into the AppHeader user dropdown.
  3. Added i18n support (English and Chinese) for the new dialog.

Does this PR introduce a user-facing change?:

web: add "About" dialog to user profile menu

How to test:

  1. Login to the dashboard.
  2. Click on the username/avatar in the top right corner.
  3. Click "About" (or "关于") in the dropdown menu.
  4. Verify the dialog opens with the correct KubeEdge logo and links.

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ddc-baiye
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @ddc-baiye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'About' dialog to the KubeEdge Dashboard, enhancing user experience by providing quick access to essential project information and external links. The dialog is accessible via the user profile menu in the top navigation bar, ensuring a consistent and intuitive interface.

Highlights

  • New About Dialog Component: A new AboutDialog component has been created to display KubeEdge project information, including the logo, a description, and official links.
  • User Profile Dropdown Integration: The 'About' menu item has been integrated into the AppHeader's user profile dropdown, providing easy access to the new dialog.
  • Internationalization Support: The new 'About' dialog includes i18n support for both English and Chinese, ensuring a localized experience for users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2025
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an 'About' dialog to the KubeEdge Dashboard. The implementation includes a new AboutDialog component and i18n strings. However, the integration into the AppHeader is incomplete and will cause a runtime error as it references an undefined state setter. Additionally, a minor improvement can be made in the new dialog to fully support internationalization by translating a hardcoded string. My review includes specific comments to address these issues.

Comment thread modules/web/src/component/Common/AppHeader/index.tsx
Comment thread modules/web/src/component/Dialog/AboutDialog/index.tsx Outdated
Signed-off-by: ddc-baiye <dongdong.chen@bluedotai.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants