🐛 Reject namespace filters for cluster-scoped resources

[dlanov]

Fixes #988.

InNamespace was silently ignored when List or DeleteAllOf targeted a cluster-scoped resource. This could turn a namespace-restricted list into an unfiltered cluster-wide list and, more seriously, turn a namespace-restricted DeleteAllOf into a cluster-wide delete-collection request.

This change:

• validates non-empty namespace options before dispatching to the typed, unstructured, metadata, or cache-backed client paths;
• returns an error when a namespace is supplied for a cluster-scoped resource;
• rejects the operation before an HTTP request is sent;
• preserves cluster-wide operations when no namespace is specified;
• normalizes functional options so each caller-supplied option is applied exactly once.

Tests cover typed, unstructured, and metadata representations for both List and DeleteAllOf, verify that rejected operations send no request, and confirm custom options are invoked only once.

A compatibility consideration is that callers passing InNamespace for cluster-scoped resources will now receive an error instead of silently performing an unscoped operation.

Validation:

go test ./pkg/client -count=1
go test ./pkg/client/fake -count=1
go test ./pkg/client/... -count=1
go test -race ./pkg/client -run '^TestClient$' -ginkgo.focus='issue #988|should invoke each caller-supplied' -count=1
go vet ./pkg/client/...
make lint

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlanov
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Welcome @dlanov!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @dlanov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.