🐛 fake: set deletionTimestamp on object passed to Delete

[dpacgdm]

Summary

• When fake Client.Delete soft-deletes an object because finalizers remain, copy deletionTimestamp onto the caller's object (same pattern as Create/Update/Get).
• Add a unit test covering that behavior.
• Adjust the existing finalizers-on-Patch test so MergeFrom preserves the timestamp now present on the deleted object.

This addresses the fake client half of #3059. The issue was later broadened to also cover the real typed client (.Error() vs .Into(obj)); that part is out of scope here and can land as a follow-up (see previously stalled #3098).

Test plan

• go test ./pkg/client/fake/

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dpacgdm
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Welcome @dpacgdm!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @dpacgdm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

/hold

Fake client should not do something the actual client doesn't do. We will have to make any change to this for the two in tandem. Its unclear if this is fixable because if the object is gone from storage, the apiserver doesn't return it in the response body

[sbueringer]

More context here: #3098