Remove usage of execSync in scripts

app/electron/main.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { ChildProcessWithoutNullStreams, exec, execSync, spawn } from 'child_process';
+import { ChildProcessWithoutNullStreams, exec, execFileSync, spawn } from 'child_process';
 import { randomBytes } from 'crypto';
 import dotenv from 'dotenv';
 import {
@@ -91,7 +91,7 @@ const args = yargs(hideBin(process.argv))
     () => {
       try {
         const backendPath = path.join(process.resourcesPath, 'headlamp-server');
-        const stdout = execSync(`${backendPath} list-plugins`);
+        const stdout = execFileSync(backendPath, ['list-plugins']);
         process.stdout.write(stdout);
         process.exit(0);
       } catch (error) {
@@ -1090,7 +1090,7 @@ async function getRunningHeadlampPIDs() {
 function killProcess(pid: number) {
   if (process.platform === 'win32') {
     // Otherwise on Windows the process will stick around.
-    execSync('taskkill /pid ' + pid + ' /T /F');
+    execFileSync('taskkill', ['/pid', String(pid), '/T', '/F']);
   } else {
     process.kill(pid, 'SIGHUP');
   }

app/scripts/build-backend.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { execSync } = require('child_process');
+const { execFileSync } = require('child_process');
 
 exports.default = async context => {
   let arch = context.arch;
@@ -15,7 +15,7 @@ exports.default = async context => {
     osName = 'Windows_NT';
   }
 
-  execSync('make backend', {
+  execFileSync('make', ['backend'], {
     env: {
       ...process.env, // needed otherwise important vars like PATH and GOROOT are not set
       GOARCH: arch,

app/scripts/start.js

@@ -4,11 +4,9 @@
  *
  * Assumes being run from within the app/ folder
  */
-const { spawn } = require('child_process');
+const { spawn, spawnSync } = require('child_process');
 const { statSync, existsSync } = require('fs');
 const { join } = require('path');
-const { execSync } = require('child_process');
-const { spawnSync } = require('child_process');
 
 /**
  * @returns the last commit date of the backend/ in milliseconds since epoch,

frontend/make-env.js

@@ -16,11 +16,13 @@
 
 'use strict';
 // Creates the .env file
-import { execSync } from 'child_process';
+import { execFileSync } from 'child_process';
 import fs from 'fs';
 const appInfo = JSON.parse(fs.readFileSync('../app/package.json', 'utf8'));
 
-const gitVersion = execSync('git rev-parse HEAD').toString().trim();
+const gitVersion = execFileSync('git', ['rev-parse', 'HEAD'], {
+  encoding: 'utf8',
+}).trim();
 
 const envContents = {
   REACT_APP_HEADLAMP_VERSION: appInfo.version,

plugins/headlamp-plugin/bin/headlamp-plugin.js

@@ -108,7 +108,7 @@ function create(name, link, noInstall) {
   } else {
     console.log('Installing dependencies...');
     try {
-      child_process.execSync('npm ci', {
+      child_process.execFileSync('npm', ['ci'], {
         stdio: 'inherit',
         cwd: dstFolder,
         encoding: 'utf8',
@@ -603,7 +603,7 @@ function runScriptOnPackages(packageFolder, scriptName, cmdLine, env) {
       console.log(`No node_modules in "${folder}" found. Running npm install...`);
 
       try {
-        child_process.execSync('npm install', {
+        child_process.execFileSync('npm', ['install'], {
           stdio: 'inherit',
           encoding: 'utf8',
         });
@@ -864,7 +864,7 @@ function getNpmOutdated() {
   let result = null;
 
   try {
-    result = child_process.execSync('npm outdated --json', {
+    result = child_process.execFileSync('npm', ['outdated', '--json'], {
       encoding: 'utf8',
     });
   } catch (error) {
@@ -1030,7 +1030,6 @@ function upgrade(packageFolder, skipPackageUpdates, headlampPluginVersion) {
         encoding: 'utf8',
       });
     } catch (e) {
-      console.error(`Problem running ${cmd}`);
       return e.status;
     }
     return 0;

tools/releaser/src/commands/start.ts

@@ -1,7 +1,7 @@
 import chalk from 'chalk';
 import path from 'path';
 import fs from 'fs';
-import { execSync } from 'child_process';
+import { execFileSync } from 'child_process';
 import { getRepoRoot, commitVersionChange } from '../utils/git.js';
 import { sanitizeVersion } from '../utils/version.js';
 
@@ -22,7 +22,10 @@ export function startRelease(releaseVersion: string): void {
 
     // Run npm install in app directory
     console.log(chalk.blue('Running npm install in app directory...'));
-    execSync('npm install', { stdio: 'inherit', cwd: path.join(repoRoot, 'app') });
+    execFileSync('npm', ['install'], {
+      stdio: 'inherit',
+      cwd: path.join(repoRoot, 'app'),
+    });
     console.log(chalk.green('✅ npm install completed'));
 
     // Commit the changes

tools/releaser/src/utils/git.ts

@@ -1,10 +1,12 @@
-import { execSync } from 'child_process';
+import { execFileSync } from 'child_process';
 import path from 'path';
 import fs from 'fs';
 
 export function getRepoRoot(): string {
   try {
-    const gitRoot = execSync('git rev-parse --show-toplevel', { encoding: 'utf-8' }).trim();
+    const gitRoot = execFileSync('git', ['rev-parse', '--show-toplevel'], {
+      encoding: 'utf-8',
+    }).trim();
     return gitRoot;
   } catch (error) {
     console.error('Error: Not in a git repository');
@@ -31,8 +33,10 @@ export function commitVersionChange(version: string): void {
   const packageLockJsonPath = path.join(repoRoot, 'app', 'package-lock.json');
 
   try {
-    execSync(`git add "${packageJsonPath}" "${packageLockJsonPath}"`);
-    execSync(`git commit --signoff -m "app: Bump version to ${version}"`);
+    execFileSync('git', ['add', packageJsonPath, packageLockJsonPath], { stdio: 'inherit' });
+    execFileSync('git', ['commit', '--signoff', '-m', `app: Bump version to ${version}`], {
+      stdio: 'inherit',
+    });
   } catch (error) {
     console.error('Error: Failed to commit version change');
     console.error(error);
@@ -42,7 +46,9 @@ export function commitVersionChange(version: string): void {
 
 export function createReleaseTag(version: string): void {
   try {
-    execSync(`git tag -a v${version} -m "Release ${version}"`);
+    execFileSync('git', ['tag', '-a', `v${version}`, '-m', `Release ${version}`], {
+      stdio: 'inherit',
+    });
   } catch (error) {
     console.error(`Error: Failed to create tag v${version}`);
     console.error(error);
@@ -52,7 +58,7 @@ export function createReleaseTag(version: string): void {
 
 export function pushTag(version: string): void {
   try {
-    execSync(`git push origin v${version}`);
+    execFileSync('git', ['push', 'origin', `v${version}`], { stdio: 'inherit' });
   } catch (error) {
     console.error(`Error: Failed to push tag v${version} to origin`);
     console.error(error);