Skip to content

headlamp-plugin: Remove unused dependencies #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
illume merged 1 commit into from
Dec 15, 2025
Merged

headlamp-plugin: Remove unused dependencies #4235

illume merged 1 commit into from
Dec 15, 2025
+1 −29

Conversation

@skoeva
Copy link
Contributor

@skoeva skoeva commented Dec 1, 2025 •
edited
Loading

This continues the work of removing unused dependencies in Headlamp.

Related issue: #3425

Testing

  • Run npm i && npm run build in headlamp-plugin and ensure no failures

@skoeva skoeva self-assigned this Dec 1, 2025
@skoeva skoeva added dependencies Pull requests that update a dependency file security headlamp-plugin Related to the headlamp-plugin NPM package. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 1, 2025
@skoeva skoeva force-pushed the unused branch 2 times, most recently from 2f06c92 to a855fcf Compare December 1, 2025 19:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2025
illume
illume reviewed Dec 2, 2025
View reviewed changes
@skoeva skoeva changed the title headlamp-plugin: load-tests: Remove unused dependencies headlamp-plugin: Remove unused dependencies Dec 5, 2025
illume
illume approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025
@illume illume added this to the v0.39.0 milestone Dec 15, 2025
@illume illume merged commit 141a066 into kubernetes-sigs:main Dec 15, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illume illume illume approved these changes

@sniok sniok Awaiting requested review from sniok

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees

@skoeva skoeva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file headlamp-plugin Related to the headlamp-plugin NPM package. security size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v0.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@skoeva @k8s-ci-robot @illume