docs: add v0.2.0 release notes#141
docs: add v0.2.0 release notes#141AvineshTripathi wants to merge 4 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| To install the controller, apply the `install.yaml` manifest for this version: | ||
|
|
||
| ```sh | ||
| kubectl apply -f https://github.com/kubernetes-sigs/node-readiness-controller/releases/download/v0.2.0/install.yaml |
There was a problem hiding this comment.
Question:
We recently introduced support for metrics and webhooks. However, in previous releases, we only provided a default install.yaml. Should we start publishing multiple versions of install.yaml like metrics-intall.yaml, or should users continue building their own from the source code?
There was a problem hiding this comment.
We could certainly add additional manifests in this release.
How about something like, install-with-secure-metrics.yaml?
I think we should also ensure we update our installation documentation flow for completeness.
There was a problem hiding this comment.
do we want the documentation changes to be part of this branch, or do we create a new one?
There was a problem hiding this comment.
I suggested an alternate for the published manifests. PTAL.
also, does this PR merge to new branch? seems to be still merging to main.
There was a problem hiding this comment.
also, does this PR merge to new branch? seems to be still merging to main.
i am a little confused here. which branch should it be pointing too?
| To install the controller, apply the `install.yaml` manifest for this version: | ||
|
|
||
| ```sh | ||
| kubectl apply -f https://github.com/kubernetes-sigs/node-readiness-controller/releases/download/v0.2.0/install.yaml |
There was a problem hiding this comment.
I suggested an alternate for the published manifests. PTAL.
also, does this PR merge to new branch? seems to be still merging to main.
|
/lgtm |
|
/approve Thanks! |
|
/hold |
|
@AvineshTripathi I added hold for you to continue on rest of the release flow as you progress. Please feel free to unhold this whenever you're ready to publish this. |
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
…metrics, and webhooks, alongside updated documentation. Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
This commit simplifies the published manifests down to 'install.yaml' and 'install-full.yaml'. Co-authored-by: ajaysundar.k <ajaysundar.k@gmail.com> Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
504347e to
e79617f
Compare
|
New changes are detected. LGTM label has been removed. |
ajaysundark
left a comment
There was a problem hiding this comment.
@AvineshTripathi Instead of this triggering v0.2.1 patch release from main, I'm wondering if it's cleaner to just create a followup v0.3.0 release with other changes?
I'm prefering this as this commit is required only for publishing new artifacts. I'll do that manually from main after this PR is merged.
We will plan v0.3.0 picking up 6fa1e93 and other changes after. wdyt?
TODO: please revert the VERSION changes so we can merge this as-is in main for v0.2.0.
|
|
||
| This page details the official releases of the Node Readiness Controller. | ||
|
|
||
| ## v0.2.0 |
There was a problem hiding this comment.
The docs now point to v0.2.0 but we are managing a v0.2.1 release, and leaving a hanging v0.2.0 :/
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AvineshTripathi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR has been split into two and merged as discussed offline /close |
|
@ajaysundark: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
related to #136
will add more description later!