feat: support static pod installation flow for control-plane nodes#162
feat: support static pod installation flow for control-plane nodes#162ajaysundark merged 9 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for node-readiness-controller canceled.
|
Karthik-K-N
left a comment
There was a problem hiding this comment.
Thank you, Overall LGTM.
Whats the way to test this locally? usually we used to build and load it into kind cluster but now we are creating with static manifest.
Does loading post cluster creation works? or should we use local registry?
Yes, loading post-creation works as kubelet will keep retrying for static-pod. we can keep it for now, once this is released, I'll update the kind-config to refer published image. |
Description
Support installing node-readiness-controller in control-plane via static-pods
Related Issue
Fixes #161
Type of Change
/kind documentation
/kind feature
Testing
Verified in kind cluster using static manifest
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?