Skip to content

Add helm chart#163

Open
honghainguyen777 wants to merge 5 commits intokubernetes-sigs:mainfrom
honghainguyen777:add-helm-chart
Open

Add helm chart#163
honghainguyen777 wants to merge 5 commits intokubernetes-sigs:mainfrom
honghainguyen777:add-helm-chart

Conversation

@honghainguyen777
Copy link

Description

Add a Helm chart for deploying the node-readiness-controller.

This chart installs the node-readiness-controller along with the required
Kubernetes resources, including:

  • Deployment for the controller
  • RBAC resources
  • Metrics and webhook services
  • ValidatingWebhookConfiguration
  • NodeReadinessRule CRD
  • Optional NodeReadinessRule resources configurable via values.yaml

The chart follows conventions used by existing charts in https://github.com/kubernetes-sigs
(e.g. descheduler) and supports customization via Helm values.

Related Issue

None

Type of Change

/kind feature

Testing

The chart was tested locally using Helm:

helm lint charts/nrr-controller
helm template charts/nrr-controller
helm install nrr charts/nrr-controller --namespace node-readiness-controller --create-namespace

Verified:

  • Controller deployment starts successfully
  • CRD is installed
  • Optional NodeReadinessRule resources render correctly when defined in values.yaml
  • Chart renders cleanly with helm template

Checklist

  • make test passes
  • make lint passes
  • make lint-chart passes
  • make build-helm passes
  • make ct-helm passes

Does this PR introduce a user-facing change?

Adds a Helm chart for deploying the node-readiness-controller, including
CRD installation and optional NodeReadinessRule resources configurable
via Helm values.

Doc #(issue)

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: honghainguyen777
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @honghainguyen777!

It looks like this is your first PR to kubernetes-sigs/node-readiness-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-readiness-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @honghainguyen777. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit eb0d1d7
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69b2983232f61d0008112e83

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants