Skip to content

Update kindscaler to wait for cgroupv2 init#165

Open
farazmd wants to merge 1 commit intokubernetes-sigs:mainfrom
farazmd:kindscaler-fix
Open

Update kindscaler to wait for cgroupv2 init#165
farazmd wants to merge 1 commit intokubernetes-sigs:mainfrom
farazmd:kindscaler-fix

Conversation

@farazmd
Copy link
Contributor

@farazmd farazmd commented Mar 12, 2026

Description

Updated kindscaler to handle cgroupv2 initialization before running kubeadm join. Also updated sed command to handle macOS BSD syntax.

Related Issue

Fixes #160

Type of Change

/kind bug

Testing

Setup kind cluster using the config provided under config/testing/kind and follow instructions for autoscaling simulation tests under docs/TEST_README.md.
The command hack/test-workloads/kindscaler.sh nrr-test 2 will wait for container to initialize cgroupv2 before running kubeadm join to join the cluster.

Checklist

  • [ x ] make test passes
  • [ x ] make lint passes

Does this PR introduce a user-facing change?

No. dev/testing utility change.

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 12, 2026
@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit 3841ec0
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69b2f6ead303100008dacf01

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @farazmd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2026
@ajaysundark
Copy link
Contributor

/lgtm
/approve
/hold

Thanks for raising this. This is more of a hack script (inspired by https://github.com/lobuhi/kindscaler/) as kind doesnt support adding nodes dynamically.

We currently dont use this in any of our testing frameworks, but could benefit us in the future, when we have some kind of prow job for minimal scalability runs. Note that we also have hack/testworkloads/kwokscaler.sh that helps us to easily scale to more numbers than kind for load-testing the controller.

/cc @Karthik-K-N

for final lgtm, who has been looking into the scalability improvements.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, farazmd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
@farazmd
Copy link
Contributor Author

farazmd commented Mar 14, 2026

@ajaysundark sgtm! I will switch to using kwokscaler for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kindscaler.sh hangs on kubeadm join due to incomplete cgroupv2 initialization

3 participants