Update kindscaler to wait for cgroupv2 init#165
Update kindscaler to wait for cgroupv2 init#165farazmd wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
Hi @farazmd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm Thanks for raising this. This is more of a hack script (inspired by https://github.com/lobuhi/kindscaler/) as kind doesnt support adding nodes dynamically. We currently dont use this in any of our testing frameworks, but could benefit us in the future, when we have some kind of prow job for minimal scalability runs. Note that we also have hack/testworkloads/kwokscaler.sh that helps us to easily scale to more numbers than kind for load-testing the controller. /cc @Karthik-K-N for final lgtm, who has been looking into the scalability improvements. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, farazmd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ajaysundark sgtm! I will switch to using kwokscaler for testing purposes. |
Description
Updated kindscaler to handle cgroupv2 initialization before running kubeadm join. Also updated
sedcommand to handle macOS BSD syntax.Related Issue
Fixes #160
Type of Change
/kind bug
Testing
Setup kind cluster using the config provided under
config/testing/kindand follow instructions for autoscaling simulation tests underdocs/TEST_README.md.The command
hack/test-workloads/kindscaler.sh nrr-test 2will wait for container to initialize cgroupv2 before running kubeadm join to join the cluster.Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
No. dev/testing utility change.