Skip to content

Adding kuberentes staging go packages to list of packages to run Windows unit tests for#544

Open
marosset wants to merge 2 commits intokubernetes-sigs:masterfrom
marosset:unit-tests-k8s-staging-packages
Open

Adding kuberentes staging go packages to list of packages to run Windows unit tests for#544
marosset wants to merge 2 commits intokubernetes-sigs:masterfrom
marosset:unit-tests-k8s-staging-packages

Conversation

@marosset
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2026
@marosset marosset added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 17, 2026
@marosset
Copy link
Copy Markdown
Contributor Author

/assign @zylxjtu @liggitt

@marosset
Copy link
Copy Markdown
Contributor Author

/hold for the CI run

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2026
…ows unit tests for

Signed-off-by: Mark Rossett <marosset@microsoft.com>
@marosset marosset force-pushed the unit-tests-k8s-staging-packages branch from 2cf2190 to 0fc93ca Compare February 17, 2026 23:53
@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented Feb 18, 2026

can you please elaborate a bit more on why do we need this?

@marosset
Copy link
Copy Markdown
Contributor Author

can you please elaborate a bit more on why do we need this?

A lot of packages under the staging directory get consumed by other projects.
It would be good to make sure applicable unit tests pass on Windows for these projects too

@marosset
Copy link
Copy Markdown
Contributor Author

There are a bunch of existing issues in the packages. I'm going to make some issues in k/k to track either addressing the issues or skipping some of the tests on Windows

Signed-off-by: Mark Rossett <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@marosset: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows 3c28c5f link false /test pull-kubernetes-unit-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants