-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: add evictAfterOOMThreshold per vpa #8692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add evictAfterOOMThreshold per vpa #8692
Conversation
4a53458 to
d1d4fb5
Compare
| // +kubebuilder:printcolumn:name="MinReplicas",type="integer",JSONPath=".spec.updatePolicy.minReplicas",priority=1 | ||
| // +kubebuilder:printcolumn:name="OOMThreshold",type="string",JSONPath=".spec.updatePolicy.evictAfterOOMThreshold",priority=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/test pull-autoscaling-e2e-vpa-actuation |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
a65c877 to
51e419d
Compare
|
/retest |
|
/test pull-autoscaling-e2e-vpa-updater |
|
/test pull-autoscaling-e2e-vpa-recommender |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
/kind api-change |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iamzili
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small nits :)
vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go
Outdated
Show resolved
Hide resolved
…alculator.go Co-authored-by: Erik Zilinsky <erik.zilinsky@gmail.com>
Co-authored-by: Erik Zilinsky <erik.zilinsky@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
@iamzili: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
|
/label tide/merge-method-squash |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: