Skip to content

Conversation

@norbertcyran
Copy link
Contributor

@norbertcyran norbertcyran commented Dec 5, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds an v1alpha1 CapacityQuota CRD proposed in #8702. The logic handling this CRD will be implemented in the next PR.

Side changes:

  • updated controller-gen - you can notice that there are slight changes in the generated code and CRDs
  • refactored automation stuff - moved CRD generation makefile commands and update-codegen script to apis module, as it wasn't working correctly in the main module

Which issue(s) this PR fixes:

Part of #8703

Special notes for your reviewer:

Most of the code is generated. The important bits are mostly in capacityquota_types.go. You can notice that this CRD looks slightly different than the others. That's because I used a newer kubebuilder scaffolding. You might also want to take a look at the changes in the update-codegen script and the Makefiles.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-area labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: norbertcyran
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @norbertcyran. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area labels Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2025
@norbertcyran norbertcyran marked this pull request as ready for review December 5, 2025 12:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and x13n December 5, 2025 12:56
@norbertcyran
Copy link
Contributor Author

/assign ellistarn towca


const (
// ResourceCPU - CPU, in cores. (500m = .5 cores)
ResourceCPU ResourceName = "cpu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional, some of these are already defined upstream if you wanted to point to them.

b.WithAPIVersion("autoscaling.x-k8s.io/v1beta1")
return b
}
func (b ProvisioningRequestApplyConfiguration) IsApplyConfiguration() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of unrelated changes. Consider separating them out.

@ellistarn
Copy link
Contributor

Nice. Overall LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants