-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add CapacityQuota API #8894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add CapacityQuota API #8894
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: norbertcyran The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @norbertcyran. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9c01551 to
b1acf5e
Compare
b1acf5e to
1ee010e
Compare
1ee010e to
29513ca
Compare
|
/assign ellistarn towca |
|
|
||
| const ( | ||
| // ResourceCPU - CPU, in cores. (500m = .5 cores) | ||
| ResourceCPU ResourceName = "cpu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional, some of these are already defined upstream if you wanted to point to them.
| b.WithAPIVersion("autoscaling.x-k8s.io/v1beta1") | ||
| return b | ||
| } | ||
| func (b ProvisioningRequestApplyConfiguration) IsApplyConfiguration() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot of unrelated changes. Consider separating them out.
|
Nice. Overall LGTM |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds an v1alpha1
CapacityQuotaCRD proposed in #8702. The logic handling this CRD will be implemented in the next PR.Side changes:
update-codegenscript toapismodule, as it wasn't working correctly in the main moduleWhich issue(s) this PR fixes:
Part of #8703
Special notes for your reviewer:
Most of the code is generated. The important bits are mostly in
capacityquota_types.go. You can notice that this CRD looks slightly different than the others. That's because I used a newer kubebuilder scaffolding. You might also want to take a look at the changes in theupdate-codegenscript and the Makefiles.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: