Skip to content

Add hjoshi123 to cert-manager-maintainers usergroup#8903

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
maelvls:add-hjoshi123-cert-manager-maintainer
Apr 3, 2026
Merged

Add hjoshi123 to cert-manager-maintainers usergroup#8903
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
maelvls:add-hjoshi123-cert-manager-maintainer

Conversation

@maelvls
Copy link
Copy Markdown
Contributor

@maelvls maelvls commented Mar 12, 2026

Hemant Joshi (@hjoshi123) was recently voted as a new maintainer for the cert-manager project as documented in cert-manager/community#67

Copilot AI review requested due to automatic review settings March 12, 2026 15:48
@k8s-ci-robot k8s-ci-robot requested a review from jeefy March 12, 2026 15:48
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 12, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maelvls / name: Maël Valais (b40b8d4)

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/community-management labels Mar 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @maelvls. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub user hjoshi123 (Hemant Joshi) to the Slack configuration so they are included in the @cert-manager-maintainers usergroup, aligning Slack access with the maintainer roster referenced in the PR description.

Changes:

  • Added a users.yaml entry mapping hjoshi123 to their Slack member ID.
  • Added hjoshi123 to the cert-manager-maintainers usergroup membership list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
communication/slack-config/users.yaml Adds the Slack member ID mapping for hjoshi123 so the user can be referenced by usergroups.
communication/slack-config/usergroups.yaml Adds hjoshi123 to the cert-manager-maintainers Slack usergroup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Hemant Joshi (@hjoshi123) was recently voted as a new maintainer for the
cert-manager project as documented in cert-manager/community#67.

This change adds him to the cert-manager-maintainers Slack usergroup to
enable efficient communication and decision-making within the maintainer team.

Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls maelvls force-pushed the add-hjoshi123-cert-manager-maintainer branch from f10c456 to b40b8d4 Compare March 12, 2026 15:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2026
@cblecker
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@maelvls
Copy link
Copy Markdown
Contributor Author

maelvls commented Mar 23, 2026

Can this one be merged? Thanks

@dims
Copy link
Copy Markdown
Member

dims commented Apr 3, 2026

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
Copy link
Copy Markdown
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, maelvls, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4df5eac into kubernetes:main Apr 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants