Skip to content

Add priority values for built-in PriorityClasses#56444

Closed
mmustafasenoglu wants to merge 1 commit into
kubernetes:mainfrom
mmustafasenoglu:fix/add-priority-values
Closed

Add priority values for built-in PriorityClasses#56444
mmustafasenoglu wants to merge 1 commit into
kubernetes:mainfrom
mmustafasenoglu:fix/add-priority-values

Conversation

@mmustafasenoglu

@mmustafasenoglu mmustafasenoglu commented Jul 8, 2026

Copy link
Copy Markdown

What this PR does

Adds the actual priority values for the built-in PriorityClasses to the Pod Priority and Preemption documentation page.

Changes

  • : 2000001000
  • : 2000000000

Why

The current documentation mentions these built-in PriorityClasses but doesn't specify their actual priority values. Users can see these values by running , but having them in the documentation provides better context when choosing priority values for custom PriorityClasses.

Fixes #54107

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 8, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: mmustafasenoglu / name: Mustafa Senoglu (cd63b12)

@kubernetes-prow kubernetes-prow Bot added the language/en Issues or PRs related to English language label Jul 8, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from shannonxtreme July 8, 2026 14:44
@kubernetes-prow

kubernetes-prow Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Welcome @mmustafasenoglu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 8, 2026
@netlify

netlify Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ad55a1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6a5205aeb65f3c0008acd622
😎 Deploy Preview https://deploy-preview-56444--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Arhell
Arhell reviewed Jul 9, 2026
View reviewed changes

@Arhell Arhell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2026
@mmustafasenoglu

mmustafasenoglu commented Jul 10, 2026

Copy link
Copy Markdown
Author

Hi! The prow bot flagged the commit message because it contains Fixes #54107 — keyword-based issue references are not allowed in Kubernetes commit messages.

To fix this, you need to amend the commit message and force push:

git checkout fix/add-priority-values
git commit --amend -m "Add priority values for built-in PriorityClasses

Add the actual priority values for system-node-critical (2000001000)
and system-cluster-critical (2000000000) to the Pod Priority and
Preemption documentation page.

Related: #54107"
git push --force

This replaces Fixes #54107 with Related: #54107 to satisfy the prow bot requirement.

@mmustafasenoglu
Add priority values for built-in PriorityClasses
0ad55a1 
Add the actual priority values for system-node-critical (2000001000)
and system-cluster-critical (2000000000) to the Pod Priority and
Preemption documentation page.

Related: kubernetes#54107
@mmustafasenoglu mmustafasenoglu force-pushed the fix/add-priority-values branch from cd63b12 to 0ad55a1 Compare July 11, 2026 08:58
@kubernetes-prow kubernetes-prow Bot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 11, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/support Categorizes issue or PR as a support question. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SayakMukhopadhyay SayakMukhopadhyay Awaiting requested review from SayakMukhopadhyay
@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme
1 more reviewer
@Arhell Arhell Arhell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/support Categorizes issue or PR as a support question. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add actual priority values for built-in PriorityClasses to documentation

2 participants

@mmustafasenoglu @Arhell