fix rule eval

[YakirOren]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved rule evaluation error handling. When a rule fails to compile, evaluation now stops immediately instead of continuing to process remaining expressions, reducing unnecessary computation and preventing inconsistent results.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified EvaluateRule function in the CEL rule manager to return immediately (false, nil) when encountering a nil compiled program from prior compilation failure, replacing the previous continue behavior that would skip to the next expression check.

Changes

Cohort / File(s)	Summary
CEL Rule Evaluation pkg/rulemanager/cel/cel.go	Changed error handling in EvaluateRule to return (false, nil) immediately upon encountering a nil compiled program instead of continuing to check remaining expressions, short-circuiting on cached compilation failures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A program nil, we now see clear,
No need to jump, let's just disappear!
Return with haste, don't linger long,
Compilation failed? We move along! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix rule eval' is vague and does not clearly describe the specific change made in the pull request.	Use a more descriptive title that explains the specific bug fix, such as 'fix rule evaluation to short-circuit on compilation failure' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/rule-eval

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pkg/rulemanager/cel/cel.go`:
- Around line 184-187: Update the misleading comment above the short-circuit
that checks the compiled program (the block that tests "if out == nil { return
false, nil }") so it accurately describes the new behavior: instead of "Skip if
program compilation failed (cached as nil)" explain that the function returns
false, nil when the compiled program is nil (e.g., compilation failed or cached
as nil). Locate the check referencing the variable `out` and the `return false,
nil` statement and replace the comment text to reflect this return behavior.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Update the comment to match the new short-circuit behavior.

The code now returns false, nil rather than skipping, so the comment is misleading.

📝 Suggested update

-		// Skip if program compilation failed (cached as nil)
+		// Short-circuit as false if program compilation failed (cached as nil)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// Skip if program compilation failed (cached as nil)
	if out == nil {
	continue
	return false, nil
	}
	// Short-circuit as false if program compilation failed (cached as nil)
	if out == nil {
	return false, nil
	}

🤖 Prompt for AI Agents

In `@pkg/rulemanager/cel/cel.go` around lines 184 - 187, Update the misleading
comment above the short-circuit that checks the compiled program (the block that
tests "if out == nil { return false, nil }") so it accurately describes the new
behavior: instead of "Skip if program compilation failed (cached as nil)"
explain that the function returns false, nil when the compiled program is nil
(e.g., compilation failed or cached as nil). Locate the check referencing the
variable `out` and the `return false, nil` statement and replace the comment
text to reflect this return behavior.