Skip to content

[scanner] fix: quality test failures — mission-control launchProgress mock (#20553)#20565

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
scanner/fix-20552
Jul 8, 2026
Merged

[scanner] fix: quality test failures — mission-control launchProgress mock (#20553)#20565
kubestellar-hive[bot] merged 2 commits into
mainfrom
scanner/fix-20552

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Summary

  • Add missing required fields to mock objects in mission-control test files.
  • line 705 and lines 311/568 call / without a null guard. The tests were written before was added as a required field to , leaving it at runtime.
  • Fix: add and the other required fields (, , , , , ) to both test mock states.

Issues closed

Fixes #20553

Issues NOT in this PR

Test plan

  • Run cd web && npx vitest run src/components/mission-control/FlightPlanBlueprint.test.tsx
  • Run cd web && npx vitest run src/components/mission-control/LaunchSequence.test.tsx

🤖 Generated with Claude Code

…st mocks

FlightPlanBlueprint.tsx (line 705) and LaunchSequence.tsx (lines 311, 568)
call state.launchProgress.flatMap/length without a null guard. The test
mock states were created before launchProgress was added as a required
field to MissionControlState, leaving it undefined at runtime.

Add launchProgress: [] and the other required fields (phase, title,
overlay, deployMode, targetClusters, aiStreaming) to bring the mocks
into conformance with the current type definition.

Fixes #20553

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 15b5a1b
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a4dfbf58984ab000820ade8

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2026
@github-actions github-actions Bot added ai-generated Pull request generated by AI tier/1-lightweight labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.


Powered by axe-core. Target: WCAG 2.1 AA compliance.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>
@kubestellar-hive kubestellar-hive Bot merged commit 49071a6 into main Jul 8, 2026
42 of 45 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-20552 branch July 8, 2026 09:24
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 49071a6cdd91bf5e709818e9e6e3303c44da6fcd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] Fix mission-control / missions component test failures (TypeError: launchProgress undefined)

1 participant