feat(cloudflared): configure deployment replicaCount only if hpa is not enabled #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice catch! Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubito Helm Charts PR Checklist
Thank you for your contribution! Please ensure the following:
Chart Version: Updated
versioninChart.yamlfor the relevant chart.[] README Update: If
values.yamlwas changed, run:Testing: Tested the chart locally, and it works as expected.
Changes Summary
When an HPA is enabled, it is recommended that the value of
spec.replicasof the Deployment be removed from its manifest, see official documentationThis PR adds a check for when autoscaling is enabled, if not enabled, use the
replicaCountvalue from the values file, else remove configuration.Related Issues