[bugfix/git_helper-20] Fixed Git Switch#22
Merged
justinkumpe merged 1 commit intomainfrom Jan 6, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts git-helper UI dimensions and fixes the branch switch logic so checking out remote branches correctly creates local tracking branches, along with a patch version bump. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
cmd_branch_switch,remote_nameis computed but never used; consider removing it to avoid dead code and potential confusion about its purpose. - The UI sizing change sets
HEIGHT=12andMENU_HEIGHT=15, which may cause dialog/menu rendering issues if the menu is taller than the container; double-check these values are consistent with the UI tool’s expectations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `cmd_branch_switch`, `remote_name` is computed but never used; consider removing it to avoid dead code and potential confusion about its purpose.
- The UI sizing change sets `HEIGHT=12` and `MENU_HEIGHT=15`, which may cause dialog/menu rendering issues if the menu is taller than the container; double-check these values are consistent with the UI tool’s expectations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update git helper script UI dimensions and fix branch switching for remote branches.
Bug Fixes:
Enhancements:
Chores: