[bugfix/git_helpers-0] Bump version to 1.0.3 and enhance UI settings#26
[bugfix/git_helpers-0] Bump version to 1.0.3 and enhance UI settings#26justinkumpe merged 1 commit intodevfrom
Conversation
Updated version number and adjusted UI tool settings for improved display.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the git-helper script to version 1.0.3 and simplifies/standardizes the TUI behavior by using fixed dialog dimensions and removing the no-shadow option for whiptail/dialog screens. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Switching from dynamic tput-based sizing to fixed HEIGHT/WIDTH values may cause layout issues on very small or very large terminals; consider at least clamping values based on terminal size instead of hard-coding them.
- The removal of the --no-shadow flag for dialog/whiptail changes the visual style globally; if this is meant to be optional, consider making it a configurable setting (e.g., via an environment variable or config flag) rather than hard-coding it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Switching from dynamic tput-based sizing to fixed HEIGHT/WIDTH values may cause layout issues on very small or very large terminals; consider at least clamping values based on terminal size instead of hard-coding them.
- The removal of the --no-shadow flag for dialog/whiptail changes the visual style globally; if this is meant to be optional, consider making it a configurable setting (e.g., via an environment variable or config flag) rather than hard-coding it.
## Individual Comments
### Comment 1
<location> `git_helpers/git-helper.sh:28-30` </location>
<code_context>
UI_TOOL=""
TITLE="Git Helper v${SCRIPT_VERSION}"
-WIDTH=70
+HEIGHT=20
+WIDTH=78
+MENU_HEIGHT=12
default_config_dir="${XDG_CONFIG_HOME:-$HOME/.config}"
CONFIG_DIR="$default_config_dir/git-helper"
</code_context>
<issue_to_address>
**issue:** Hard-coding HEIGHT/WIDTH can break on terminals smaller than 20x78, whereas the previous dynamic sizing handled this edge case.
The previous use of `tput lines` let dialogs adapt to small terminals and avoided "screen too small" errors. With fixed `HEIGHT=20` and `WIDTH=78`, users on smaller terminals (e.g., narrow splits/SSH) may get failures or unusable dialogs. If you prefer fixed defaults, consider at least clamping these values to the current terminal size (via `tput lines`/`tput cols` when available) to preserve behavior on constrained environments.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| HEIGHT=20 | ||
| WIDTH=78 | ||
| MENU_HEIGHT=12 |
There was a problem hiding this comment.
issue: Hard-coding HEIGHT/WIDTH can break on terminals smaller than 20x78, whereas the previous dynamic sizing handled this edge case.
The previous use of tput lines let dialogs adapt to small terminals and avoided "screen too small" errors. With fixed HEIGHT=20 and WIDTH=78, users on smaller terminals (e.g., narrow splits/SSH) may get failures or unusable dialogs. If you prefer fixed defaults, consider at least clamping these values to the current terminal size (via tput lines/tput cols when available) to preserve behavior on constrained environments.
Updated version number and adjusted UI tool settings for improved display.
Summary by Sourcery
Update git-helper UI configuration and version number.
Bug Fixes:
Enhancements:
Chores: