Skip to content

[bugfix/git_helpers-0] Bump version to 1.0.3 and enhance UI settings#26

Merged
justinkumpe merged 1 commit intodevfrom
bugfix/git_helpers-0
Jan 7, 2026
Merged

[bugfix/git_helpers-0] Bump version to 1.0.3 and enhance UI settings#26
justinkumpe merged 1 commit intodevfrom
bugfix/git_helpers-0

Conversation

@justinkumpe
Copy link
Member

@justinkumpe justinkumpe commented Jan 7, 2026

Updated version number and adjusted UI tool settings for improved display.

Summary by Sourcery

Update git-helper UI configuration and version number.

Bug Fixes:

  • Standardize fixed dialog dimensions to avoid overly tall menus on large terminals.

Enhancements:

  • Remove no-shadow option from dialog and whiptail invocations for more consistent UI rendering.
  • Set explicit dialog height, width, and menu height defaults for a more predictable UI layout.

Chores:

  • Bump git-helper script version from 1.0.2 to 1.0.3.

Updated version number and adjusted UI tool settings for improved display.
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the git-helper script to version 1.0.3 and simplifies/standardizes the TUI behavior by using fixed dialog dimensions and removing the no-shadow option for whiptail/dialog screens.

File-Level Changes

Change Details Files
Bump script version and adjust global UI sizing constants.
  • Incremented SCRIPT_VERSION from 1.0.2 to 1.0.3.
  • Replaced previous single WIDTH definition with explicit HEIGHT, WIDTH, and MENU_HEIGHT constants (20, 78, and 12 respectively) for dialog layout.
  • Removed dynamic dialog/menu height calculation functions and associated initialization of HEIGHT and MENU_HEIGHT.
git_helpers/git-helper.sh
Standardize whiptail/dialog invocations by removing the no-shadow flag.
  • Updated all whiptail menu, checklist, inputbox, yesno, and textbox calls to drop the --no-shadow option while keeping titles and sizing parameters unchanged aside from the global constants.
  • Updated all dialog menu, checklist, inputbox, yesno, and textbox calls to drop the --no-shadow option while keeping titles and sizing parameters unchanged aside from the global constants.
git_helpers/git-helper.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@justinkumpe justinkumpe enabled auto-merge (rebase) January 7, 2026 14:48
@justinkumpe justinkumpe disabled auto-merge January 7, 2026 14:48
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Switching from dynamic tput-based sizing to fixed HEIGHT/WIDTH values may cause layout issues on very small or very large terminals; consider at least clamping values based on terminal size instead of hard-coding them.
  • The removal of the --no-shadow flag for dialog/whiptail changes the visual style globally; if this is meant to be optional, consider making it a configurable setting (e.g., via an environment variable or config flag) rather than hard-coding it.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Switching from dynamic tput-based sizing to fixed HEIGHT/WIDTH values may cause layout issues on very small or very large terminals; consider at least clamping values based on terminal size instead of hard-coding them.
- The removal of the --no-shadow flag for dialog/whiptail changes the visual style globally; if this is meant to be optional, consider making it a configurable setting (e.g., via an environment variable or config flag) rather than hard-coding it.

## Individual Comments

### Comment 1
<location> `git_helpers/git-helper.sh:28-30` </location>
<code_context>
 UI_TOOL=""
 TITLE="Git Helper v${SCRIPT_VERSION}"
-WIDTH=70
+HEIGHT=20
+WIDTH=78
+MENU_HEIGHT=12
 default_config_dir="${XDG_CONFIG_HOME:-$HOME/.config}"
 CONFIG_DIR="$default_config_dir/git-helper"
</code_context>

<issue_to_address>
**issue:** Hard-coding HEIGHT/WIDTH can break on terminals smaller than 20x78, whereas the previous dynamic sizing handled this edge case.

The previous use of `tput lines` let dialogs adapt to small terminals and avoided "screen too small" errors. With fixed `HEIGHT=20` and `WIDTH=78`, users on smaller terminals (e.g., narrow splits/SSH) may get failures or unusable dialogs. If you prefer fixed defaults, consider at least clamping these values to the current terminal size (via `tput lines`/`tput cols` when available) to preserve behavior on constrained environments.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +28 to +30
HEIGHT=20
WIDTH=78
MENU_HEIGHT=12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Hard-coding HEIGHT/WIDTH can break on terminals smaller than 20x78, whereas the previous dynamic sizing handled this edge case.

The previous use of tput lines let dialogs adapt to small terminals and avoided "screen too small" errors. With fixed HEIGHT=20 and WIDTH=78, users on smaller terminals (e.g., narrow splits/SSH) may get failures or unusable dialogs. If you prefer fixed defaults, consider at least clamping these values to the current terminal size (via tput lines/tput cols when available) to preserve behavior on constrained environments.

@justinkumpe justinkumpe merged commit 50e544e into dev Jan 7, 2026
2 of 3 checks passed
@justinkumpe justinkumpe deleted the bugfix/git_helpers-0 branch January 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant