fix(bin): prevent apostrophes from breaking fm-brief parsing - #1154
Closed
mertnesvat wants to merge 3 commits into
Closed
fix(bin): prevent apostrophes from breaking fm-brief parsing#1154mertnesvat wants to merge 3 commits into
mertnesvat wants to merge 3 commits into
Conversation
4 tasks
mertnesvat
force-pushed
the
fm/repair-fm-brief-parser
branch
from
July 28, 2026 18:40
7b04ce9 to
56855d5
Compare
Owner
|
thanks for digging into this. i merged #1093, which fixes the same bash 3.2 parse failure by moving the DOD heredocs out of command substitution, so the apostrophe wording no longer needs to change. closing this one as superseded. appreciate the help here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The developer wanted the existing fm-brief Bash parser regression fix completed and shipped as a pull request to kunchenguid/firstmate, with the branch pushed through the approved mertnesvat/firstmate fork and without changing origin authority or merging. The intended change removes the apostrophe-sensitive wording inside the nested no-mistakes Definition-of-done heredoc, updates the related authority assertion, adds direct parser and brief regression coverage, and preserves the prior edit-site durability documentation and established Firstmate contracts. They required carrying forward the preserved commits non-destructively, validating Bash syntax, targeted and standard tests, and lint where the pinned ShellCheck is available, while documenting any ShellCheck limitation. After validation configuration issues were resolved, they explicitly asked to rerun no-mistakes with Codex gpt-5.6-sol, drive every gate without --yes through a checks-green upstream PR, and include the user-visible impact, root cause, exact fix, coverage, and test evidence in the PR explanation.
What Changed
fm-briefBash parsing inside the nested Definition-of-done heredoc.Risk Assessment
✅ Low: Captain, the change is narrowly scoped, preserves authority semantics, and adds appropriate parser and generated-brief regression coverage with no material source risks found.
Testing
Diff and guidance inspection, both focused canonical test scripts, Bash parsing, and an end-to-end no-mistakes brief scaffold succeeded; the artifact confirms apostrophe-safe wording, preserved backticks, and no heredoc leakage.
Evidence: End-to-end fm-brief CLI transcript
Evidence: Generated no-mistakes implementation brief
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspected repository guidance and the base-to-target diff.bin/fm-test-run.sh tests/fm-brief.test.shbin/fm-test-run.sh tests/fm-ask-user-authority.test.shbash -n bin/fm-brief.shFM_HOME=<evidence-home> bin/fm-brief.sh parser-fix-demo demo-project, followed by direct inspection of its generated Definition-of-done section✅ **Document** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.