docs: document Codex primary launch requirement#876
Open
crumgary wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Create a clean replacement PR against crumgary/firstmate:main documenting the Codex primary launch requirement after closed PR #1. Modify README.md only. At the primary-session startup surface, add the exact command
codex -s danger-full-access; briefly explain that Codex's normal sandbox places model-generated shell commands in an isolated PID namespace so Firstmate's session-lock ancestry check cannot see the long-lived Codex process; show the exact pre-change messageerror: cannot locate harness process in ancestryas a recognizable example; and keep sandbox mode distinct from approval policy, including the verified approval-preserving formcodex -s danger-full-access -a on-request. The branch must be based on approved fork main SHA 5140413, must not use commits from rejected PR #1, and the PR description must explicitly say the change is documentation-only and supersedes closed PR #1.What Changed
codex -s danger-full-access, because Codex's normal sandbox isolates model-generated shell commands in a separate PID namespace where Firstmate's session-lock ancestry check cannot see the long-lived Codex process.error: cannot locate harness process in ancestryas a recognizable example, and clarified that sandbox mode is distinct from approval policy by showing the approval-preserving formcodex -s danger-full-access -a on-request.Risk Assessment
✅ Low: A documentation-only, well-bounded README addition that faithfully satisfies every required intent criterion with accurate, unambiguous content and no code impact.
Testing
Exercised the change as a documentation-only README edit: verified the git constraints (single README.md commit atop approved SHA 5140413, no PR #1 lineage), confirmed every required intent string appears at the primary-session startup surface, and verified the documented error message matches the real string emitted in bin/fm-lock.sh so the doc is accurate. Captured a rendered screenshot of the new section as reviewer-visible visual evidence. The intent's PR-description requirements (documentation-only, supersedes closed PR #1) could not be validated because no PR exists on this branch yet - that text is produced at PR-creation time and is outside the diff, so it is not verifiable from the branch here.
/tmp/no-mistakes-evidence/01KY5R34DGPV725WVVVTWWGE40/readme-codex-render.png)Evidence: Documented error matches source (bin/fm-lock.sh:52)
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff --stat 51404137..614a442— confirmed README.md is the only file changed (+17/-1)git rev-parse 614a442^== approved SHA 51404137 — branch based on approved fork main, single clean commit not built on PR #1grep -Fon README.md for each required string:codex -s danger-full-access,codex -s danger-full-access -a on-request,error: cannot locate harness process in ancestry,isolated PID namespace,session-lock ancestry check,Sandbox mode is separate from approval policy— all presentCross-checked documented error string against source:bin/fm-lock.sh:52emits the identicalerror: cannot locate harness process in ancestrymessageRendered the new README Getting Started section to a GitHub-style HTML page and captured a full-page screenshot via headless Chromiumgit status --porcelain— working tree clean, no transient artifacts left✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.