add support for half-precision data#20
Open
magnesium2400 wants to merge 1 commit intokwikteam:masterfrom
Open
Conversation
kalvdans
approved these changes
Mar 10, 2025
kalvdans
left a comment
kalvdans
left a comment
There was a problem hiding this comment.
Looks solid to me, half.typecast does not change the underlying bit pattern.
|
|
||
| % read the data | ||
| data = fread(fid, prod(shape), [dataType '=>' dataType]); | ||
| if ishalf; data = half.typecast(data); end |
There was a problem hiding this comment.
Nit: move this code outside of the try-catch body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if half-precision: read as 16bit uint and typecast back to half type