Use intrinsic height for scroll snapshots - #196
Open
kyleve wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review notes
Device full-content sizing is now
max(device viewport height, settled full-content height): 874 points for the iPhone preset and 1194 points for the iPad preset. Generic custom full-content frames continue to shrink-wrap unless callers explicitly provide a minimum height.Full-content measurement adds a full-width scrolling descendant's content size and adjusted insets to the surrounding root chrome. Intentionally bounded split layouts snapshot their shared scrolling child instead of adding snapshot-only production sizing behavior.
A measurement that does not converge after the settling budget records a test issue and skips comparison/recording, so an arbitrary intermediate height can never be blessed as a reference.
Testing
./swiftformat --lintswift run bumper config .swift run bumper test .swift run bumper lint . --timings./test SnapshotKitTests SnapshotKitTestingTests --no-generate(69 tests passed)./test WhereUITests --no-generate(356 tests passed)./test --all --no-generate(1,644 tests passed)./test --snapshots --review./test --snapshots --record failed./test --snapshots --no-generate(34 snapshot tests passed)